rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

`test_restored_packages_retry` is brittle

Open valentinewallace opened this issue 1 year ago • 3 comments

test_restored_packages_retry broke in #2288 and again in #2697.

Per https://github.com/lightningdevkit/rust-lightning/pull/2697#issuecomment-1789411564, it will break every time we add a fetch for random bytes on startup.

To fix this, make the random bytes deterministic within the test using TestKeysInterface::override_random_bytes and regenerate the monitor by logging it in the parent commit of https://github.com/lightningdevkit/rust-lightning/commit/a3b416a32ca967e8b2ef4adb3d97c3a447becda9#diff-6b0cbdb9c86bfc52581a89ea5c23454f692199b2192be965f34a47429b3cf912R1748, right above the linked test line.

valentinewallace avatar Jan 12 '24 22:01 valentinewallace

Hi there, I've solved this issue on my local repo. Just wanted to ask if I can make a PR right away or do I need to be assigned the issue?

Harsh1s avatar Jan 17 '24 12:01 Harsh1s

Hi there, I've solved this issue on my local repo. Just wanted to ask if I can make a PR right away or do I need to be assigned the issue?

Feel free to open a PR!

valentinewallace avatar Jan 17 '24 15:01 valentinewallace

Note that #3302 improves this a bit, even if it doesn't fix it.

TheBlueMatt avatar Sep 09 '24 23:09 TheBlueMatt