tgreenx
tgreenx
> Unlike most messages where zonemaster-engine has received a response and is able to critique what it receives, and can thus reasonable assert that what it got was what the...
> > Perhaps we could simply reword it as such instead: > > `No response received from nameserver {ns} to {query_type} query` (or `queries`, if applicable) > > I think...
@matsduf All tests now pass and I've addressed your comments, please re-review.
> I see that `t/translator.t` contains the following test that naturally fails after this update: > > ``` > ok( exists $trans->data->{DNSSEC}{ALGORITHM_OK}, 'expected key from module exists' ); > ```...
> From the description of [zonemaster/zonemaster#1425](https://github.com/zonemaster/zonemaster/pull/1425): > > ``` > After this update, DNSSEC07 should still be run first, and then DNSSEC11. If updated DNSSEC07 outputs DS07_NOT_SIGNED then no other...
> Besides that DNSSEC11 should always be run it looks fine. All scenarios pass. Updated and rebased on top of #1475
Unit test data for t/Test-dnssec.t needs to be re-recorded in order for all unit tests to pass, but that can't be done right now (zut-root.rd.nic.fr is temporarily offline). It will...
@matsduf please re-review, unit tests have been re-recorded (the test zones are back online).
> The **NOT_SIGNED** tag should be cleaned away, but it does no harm. The cleaning could also be done later. Done (removed). I've also rebased and fixed several conflicts. Please...
@matsduf All unit tests now pass and your comments have been addressed, please re-review.