zonemaster-engine icon indicating copy to clipboard operation
zonemaster-engine copied to clipboard

Reword `does not respond` messages

Open jsoref opened this issue 8 months ago • 6 comments

https://github.com/search?q=repo%3Azonemaster%2Fzonemaster-engine+%2Fname+%3Fserver.*+does+not+respond%2F+NOT+language%3A%22Gettext+Catalog%22+language%3APerl++NOT+path%3A%2F%5Et%5C%2F%2F&type=code

https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Basic.pm#L252

see #1353 for name server vs nameserver

https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L193 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L197 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L201 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L237 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L241 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L245 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Zone.pm#L405

Unlike most messages where zonemaster-engine has received a response and is able to critique what it receives, and can thus reasonable assert that what it got was what the server sent, when zonemaster-engine doesn't receive a response, it doesn't actually know if the server didn't receive the request, didn't send a response, or if the response was lost somewhere along the way.

It would be better to say:

Did not receive response to query for X via Y from name server {ns}

query for X via Y could be:

  • NS queries over UDP
  • NS queries over TCP
  • SOA queries over UDP
  • any queries over UDP
  • NS queries over TCP
  • any queries over TCP
  • an SOA query

name server could be:

  • name server
  • SOA MNAME name server

jsoref avatar May 31 '24 14:05 jsoref