zonemaster-engine icon indicating copy to clipboard operation
zonemaster-engine copied to clipboard

Update DNSSEC05 implementation

Open tgreenx opened this issue 2 months ago • 6 comments

Purpose

This PR proposes an update of test case DNSSEC05 implementation.

Context

Test case specification: https://github.com/zonemaster/zonemaster/pull/1409 Test scenarios specification: https://github.com/zonemaster/zonemaster/pull/1410

Changes

  • Update implementation (test case, message tags, profile, DNSSEC algorithms table)
  • Update unit tests
  • Update unit test data

How to test this PR

Unit tests are created and should pass.

tgreenx avatar Oct 28 '25 16:10 tgreenx

You do not want to use the new unit test file format introduced by #1467?

matsduf avatar Oct 29 '25 12:10 matsduf

For scenario SHARED-IP-1 I get

$ zonemaster-cli --hints=hintfile.zone --test=dnssec05 --level=info --show-testcase --raw SHARED-IP-1.dnssec05.xa                                           
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v8.0.0                                                                                              
   0.05 INFO     DNSSEC05       DS05_ALGO_OK  algo_descr=ECDSA Curve P-256 with SHA-256; algo_mnemo=ECDSAP256SHA256; algo_num=13; keytag=51298; ns_list=ns1\
a.shared-ip-1.dnssec05.xa/127.15.5.31

but it should be ns_list=ns1a.shared-ip-1.dnssec05.xa/127.15.5.31;ns1b.shared-ip-1.dnssec05.xa/127.15.5.31

matsduf avatar Oct 29 '25 14:10 matsduf

For all athor scenarios I get the correct output when running zonemaster-cli based on this update.

matsduf avatar Oct 29 '25 14:10 matsduf

@matsduf All tests now pass and I've addressed your comments, please re-review.

tgreenx avatar Oct 30 '25 09:10 tgreenx

I see that t/translator.t contains the following test that naturally fails after this update:

ok( exists $trans->data->{DNSSEC}{ALGORITHM_OK},    'expected key from module exists' );

matsduf avatar Oct 30 '25 10:10 matsduf

I see that t/translator.t contains the following test that naturally fails after this update:

ok( exists $trans->data->{DNSSEC}{ALGORITHM_OK},    'expected key from module exists' );

Indeed, fixed.

tgreenx avatar Oct 30 '25 14:10 tgreenx