zonemaster
Update DNSSEC07 implementation
Purpose
This PR proposes an update of test case DNSSEC07 implementation.
Context
Test case specification: https://github.com/zonemaster/zonemaster/pull/1425 Test scenarios specification: https://github.com/zonemaster/zonemaster/pull/1432
Changes
- Update implementation (test case, message tags, profile, DNSSEC module test plan)
- Update unit tests
- Update unit test data
How to test this PR
Unit tests are updated and should pass.
From the description of zonemaster/zonemaster#1425:
After this update, DNSSEC07 should still be run first, and then DNSSEC11. If updated DNSSEC07 outputs DS07_NOT_SIGNED then no other test cases, besides DNSSEC11, in DNSSEC module should be run.I.e. DNSSEC07 and DNSSEC11 should always be run.
Should that be included in the specification? I do not think so, but it should be stated somewhere.
For that purpose with have the "Special procedural requirements" section in the specification, which I followed. But it seems it was not entirely updated correctly then.
Besides that DNSSEC11 should always be run it looks fine. All scenarios pass.
Updated and rebased on top of #1475
Unit test data for t/Test-dnssec.t needs to be re-recorded in order for all unit tests to pass, but that can't be done right now (zut-root.rd.nic.fr is temporarily offline). It will be done at a later time.
Unit test data for t/Test-dnssec.t needs to be re-recorded in order for all unit tests to pass, but that can't be done right now (zut-root.rd.nic.fr is temporarily offline). It will be done at a later time.
I suggest that the failing tests are marked as TODO. What test cases are affected? I could possibly create scenarios for them.
@matsduf please re-review, unit tests have been re-recorded (the test zones are back online).
It does not look like the tag NOT_SIGNED show up in the output, which seems strange.
It is not strange. It is outputted, but on DEBUG level. If level is set to DEBUG in zonemaster-cli it is outputted.
The NOT_SIGNED tag should be cleaned away, but it does no harm. The cleaning could also be done later.
Done (removed). I've also rebased and fixed several conflicts. Please re-review