tgreenx
tgreenx
@mattias-p @matsduf @marc-vanderwal please (re-)review.
@matsduf @mattias-p @marc-vanderwal Rebased on latest develop, and addressed review comments (see https://github.com/zonemaster/zonemaster-cli/pull/421/commits/acf65f511822f78d551d2ba82d8dd753790c5ba4). Please re-review.
@matsduf @mattias-p @marc-vanderwal please re-review this PR.
> [ ... ] > * Refactoring of section mapping of data for both outputs. Grand total is to be included in the JSON output. I created https://github.com/zonemaster/zonemaster-cli/issues/440 for this.
Solved by #1189 (release v2023.2)
@tolvmannen @matsduf This PR is now ready for review. Note that unit tests are updated and should all pass, which is the case for specific test scenarios of Address01 located...
@matsduf @tolvmannen please re-review
> Only recreation of the data file is needed. @matsduf @tolvmannen Done. Also updated message ids to "address(es)". Please re-review.
@marc-vanderwal Do you think this issue be closed or kept? I also do not see a sizable issue here, but if you disagree could you maybe elaborate more on it?