tgreenx

Results 178 comments of tgreenx

> @mattias-p, please set correct `V-XXX` and `RC-XXX` labels on it. @mattias-p @matsduf I've set RC-Deprecations and V-Patch (maybe V-Minor instead? I'm not sure).

Fixed by #1456 in release v2025.1. > 2. A second step would be: > > 1. Create a script that does the update to make the update simple. > 2....

@matsduf @marc-vanderwal thanks, I have updated the unit tests and this PR is now ready for review. In particular, see the handling of specific root hints for scenarios `NO-SPF-ROOT-ZONE, NULL-SPF-ROOT-ZONE,...

> Given that the domain-specific language in #1467 is merged, why not use that? It also supports replacing the root hints on the fly for subsequent scenarios. > Have you...

@matsduf @marc-vanderwal please re-review

Partly fixed by #1402, which fixes the leaking but also disable the testing of those test cases for pre-recorded data. A more complete solution would need to use a fixed...

Also see https://github.com/zonemaster/zonemaster/issues/1009

> I'm happy to create a PR for this if you're open to it. Yes of course, please do, much appreciated !

Hi @jsoref, what is the status of this issue? I see you opened a draft PR on your fork, is it complete?

No worries, just checking in, you can take your time. We just had a new release so the next one won't happen before a little while. Thanks again.