tgreenx
tgreenx
> TODO in this PR: fix usage of `asn_db.sources` (see [#1311 (comment)](https://github.com/zonemaster/zonemaster-engine/pull/1311#issuecomment-1845380408)) Now done in commit https://github.com/zonemaster/zonemaster-engine/pull/1257/commits/37ede6623a546dd8367f0321c101422daefe225c. This PR should now be complete. @matsduf @marc-vanderwal @mattias-p please re-review. Note that...
> If two different strings have been configured for ASN lookup, I assume that the second is some kind of backup. When will the failover to the backup happen? Is...
> From the code I do not see how the switch to next ASN provider is done, but I assume that it should be done when the response is not...
> > Regarding the DEBUG message, it would currently be complex to do that but instead I can make one that it outputted whenever any ASN source is used (not...
@matsduf @mattias-p please (re-)review
Solved by #1040 (and https://github.com/zonemaster/zonemaster-cli/pull/357 and https://github.com/zonemaster/zonemaster-backend/pull/1132) in v2024.1.
Considering the above comments, this work is put on hold until next release.
Zonemaster-LDNS now have proper CDS/CDNSKEY RRs support, see https://github.com/zonemaster/zonemaster-ldns/pull/199. However the issue raised here isn't actually solved by this added support. The responsibility lies in LDNS itself. It should be...
I would vote for keeping the current variable name (`retry`), make it not count the initial query, and change its documentation; it has the benefits of being in line with...
I have proposed #1258 as a solution.