Shane Smiskol comments

Results 1136 comments of


                                            Shane Smiskol

wifimanager: use asyncCall to avoid timeout when adding connections

We also need this for the hotspot connection

wifimanager: use asyncCall to avoid timeout when adding connections

This won't work for the hotspot, as in `setTetheringEnabled`, we'll end up calling `activateWifiConnection` with the tethering connection not yet in the knownConnections

wifimanager: use asyncCall to avoid timeout when adding connections

merging the asyncCall change, all it will do is silence the timeout warning as this function is already practically async anyway already

calibrationd: add hysteresis on calibration validity

Here's a dongle where this happens occasionally: `9227902ca7eb7bba`. user states that higher speeds cause the alert more often. (Device is pointed 4 degrees to the right, limit is 3.96)

Low speed steer saturation warning false positives in Tesla

- use the past desired acceleration compared to current acceleration instead of current acceleration and action acceleration (expected to differ)

Subaru LKAS Angle safety model

We've moved the car safety code into [opendbc](https://github.com/commaai/opendbc/tree/master/opendbc/safety), please rebase and re-open your PR there!

GM: Very slow acceleration when resuming from a stop or slow roll

@Verylukyguy if you can rally the other ICE GMs to gather routes from a stop, that will help us raise the ICE gas/regen limit across the board.

GM: Very slow acceleration when resuming from a stop or slow roll

@1454 please provide a route with openpilot toggled off in the Device settings, and have the car come from a stop to at least 30 mph on flat ground. This...

GM: Very slow acceleration when resuming from a stop or slow roll

@Verylukyguy anything from closer to a stop?

GM: Very slow acceleration when resuming from a stop or slow roll

From cookiemonster: fe80a4e1cedec853|2023-08-08--08-58-41