openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

wifimanager: use asyncCall to avoid timeout when adding connections

Open deanlee opened this issue 1 year ago • 3 comments

resolve: https://github.com/commaai/openpilot/issues/34271

deanlee avatar Dec 17 '24 07:12 deanlee

UI Preview

All Screenshots

github-actions[bot] avatar Dec 17 '24 07:12 github-actions[bot]

We also need this for the hotspot connection

sshane avatar Dec 17 '24 07:12 sshane

The same approach has been applied to the hotspot

deanlee avatar Dec 17 '24 08:12 deanlee

This won't work for the hotspot, as in setTetheringEnabled, we'll end up calling activateWifiConnection with the tethering connection not yet in the knownConnections

sshane avatar Dec 17 '24 21:12 sshane

merging the asyncCall change, all it will do is silence the timeout warning as this function is already practically async anyway already

sshane avatar Dec 17 '24 22:12 sshane