Shane Smiskol

Results 1136 comments of Shane Smiskol

As noted in that PR, it does not change any behavior. We still have to change the max value dependant on the car. A recent route is a good idea.

Does the 3X recognize the error or is it only displayed on the car? Is this a permanent lockout, or does it show temporarily and go away? Can you re-engage...

You're using always on lateral on a fork. We don't usually look into issues present on a fork. Can you reproduce on stock? If not, you should contact sunny

At first this will just test the actuation limits and set controls_allowed to True always, then we need to fix the multitude of errors when you let safety run independant...

I also am noticing this non-linear response on my Camry. On Jan 23 torqued was using much higher values (similar to offline values in the toml file), but now they've...

Not sure, but it's a new development. I don't see tearing, but the positioning of the toggle element that moves is jittery. Seems like a QT bug

We've moved the car interfacing code to our [`opendbc`](https://github.com/commaai/opendbc) repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against [`opendbc`](https://github.com/commaai/opendbc) at your...

I wonder how many other skipping counter cases I've seen were actually just delayed messages, and not as severe car bugs...

@deanlee interested in this? Just thinking out loud, and not a priority, but I wonder how nice it would be if Cabana could take over the last few bits that...

- Motor fault from troy: 0c832cd010dc203a/00000039--36cfb0e2a3/1 - Motor fault from rawsignal: https://connect.comma.ai/574129f33798790b/0000001f--1299806aaf