openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

calibrationd: add hysteresis on calibration validity

Open adeebshihadeh opened this issue 2 years ago • 4 comments

This should prevent mountings that are right on the edge of the bounds from being able to engage sometimes.

adeebshihadeh avatar Apr 03 '23 21:04 adeebshihadeh

Here's a dongle where this happens occasionally: 9227902ca7eb7bba. user states that higher speeds cause the alert more often. (Device is pointed 4 degrees to the right, limit is 3.96)

sshane avatar Apr 13 '23 23:04 sshane

This guy's having a bad time with calibration letting him engage sometimes: 5548e173b952a76b|2023-07-08--14-43-34

adeebshihadeh avatar Jul 14 '23 02:07 adeebshihadeh

Device is pointed 4 degrees to the right, limit is 3.96

Current understanding is that the Comma wasn't properly seated in the mount at the time, so if comparing different drives, please keep in mind.

beej avatar Jul 15 '23 15:07 beej

Another user hitting this: 91138069575407d3.

adeebshihadeh avatar Jun 04 '24 17:06 adeebshihadeh