Shane Smiskol
Shane Smiskol
We need to make sure that this can restrict Teslas within a certain model year/capability range. For example, not HW2 (or others), and not Model S/X right now.
Also see this comment: https://github.com/commaai/opendbc/issues/1917#issuecomment-2740315033
We can potentially detect these missing APIs in the interface and set the dashcam flag if needed similar to Ford: https://github.com/commaai/opendbc/blob/1cc799801f03a45180de1e64193981b102aec5c4/opendbc/car/ford/interface.py#L70-L79
We should only ever use the VIN or the fingerprint to make this easier to reason about, not both
merge please
not important to do any time soon since we error correct on the new Toyota long tune, just opened to note this issue
We've moved the car interfacing code to our [`opendbc`](https://github.com/commaai/opendbc) repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against [`opendbc`](https://github.com/commaai/opendbc) at your...
Fixed in https://github.com/commaai/openpilot/pull/34390
We've moved the car interfacing code to our [`opendbc`](https://github.com/commaai/opendbc) repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against [`opendbc`](https://github.com/commaai/opendbc) at your...
Can we link to a common readme?