Shane Smiskol

Results 1136 comments of Shane Smiskol

You can open the PR now, we need to test on a few brands here to make sure it all works

Has a CAN FD radar bus. Please try this branch: https://github.com/commaai/openpilot/tree/cn7c-elantra

Nice! Can you drive more to gather more lateral control data? I'll get https://github.com/commaai/openpilot/pull/30219 cleaned up and merged shortly after once we verify that lateral control is as we expect...

Need some more curves I believe!

High speed (> 80 km/h) and engaged curves I mean

@1okko can you get more driving data please? Then we can merge!

| Dongle, platform, VIN | Name from VIN ๐Ÿ†š CarDocs | Segments | Bad seg tags | Good seg tags | |:--------------------------------------------------------------------------------------------------------------------------------|:---------------------------|:----------------------------------------|:---------------|:------------------------------------------------------| | [d01e5725e5587ae3](https://useradmin.comma.ai/?onebox=d01e5725e5587ae3)HYUNDAI_ELANTRA_2021000000000........ | None ๐Ÿ†šNone | 4 routes,94...

Need a little more sharper turns at high speeds, the torqued learner doesn't have many data points there.

| Dongle, platform, VIN | Name from VIN ๐Ÿ†š CarDocs | Segments | Bad seg tags | Good seg tags | |:--------------------------------------------------------------------------------------------------------------------------------|:---------------------------|:-----------------------------------------|:-------------------------------------------------------------------------------------------------------------|:-----------------------------------------------------------------------------------| | [d01e5725e5587ae3](https://useradmin.comma.ai/?onebox=d01e5725e5587ae3)HYUNDAI_ELANTRA_2021000000000........ | None ๐Ÿ†šNone | 6 routes,181...

I forgot this port requires changing the length of `LFAHDA_MFC`, we'll have to put this off for now until we have time for a car porting sprint. Feel free to...