Sylwester Arabas

Results 518 comments of Sylwester Arabas

thanks @erosky & @AgnieszkaZaba !

Thank you @AgnieszkaZaba and @erosky This PR addresses: - #1554 - #1321 Kudos! It introduces: - #1588 The only change, I'd suggest to add before merging is at least minimal...

Hmm... it seems that this change was committed straight to `main` here: https://github.com/open-atmos/PySDM/commit/16f2f99ee1e9266c7cfe9c60dc255cef445146c3 Still, test would be needed, keeping open

@Sfonxu, WOW, it seems that bumping pylint job to Python 3.13 will not work: ``` PyMPDATA/solver.py:1:0: F0002: PyMPDATA/solver.py: Fatal error while checking 'PyMPDATA/solver.py'. Please open an issue in our bug...

closing & reopening to trigger CI build against current main

> I also have no idea how to make Codecov realize we are actually testing both variants of `clock` during CI runs Seems to work with changes in https://github.com/open-atmos/PyMPDATA/pull/553/commits/5f88435464f78809f5580eedc30e78c4341abb4b and...

@Sfonxu, the CI build now fails with: ``` Error: --> src/main.rs:43:60 | 43 | let stepper_arg = vec![("options", options),("n_dims", 2)].into_py_dict_bound(py); | ^ expected `Bound` found type `{integer}` ```

kudos @Sfonxu ! Mergin, but also adding a new issue: https://github.com/open-atmos/PyMPDATA/issues/469