PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

Add kinetic fractionation factor from Bolot 2013

Open AgnieszkaZaba opened this issue 10 months ago • 1 comments

AgnieszkaZaba avatar Apr 12 '25 01:04 AgnieszkaZaba

thanks @erosky & @AgnieszkaZaba !

slayoo avatar Apr 12 '25 09:04 slayoo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.49%. Comparing base (9fe8433) to head (a95aaa4). Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
+ Coverage   85.48%   85.49%   +0.01%     
==========================================
  Files         392      393       +1     
  Lines        9556     9571      +15     
==========================================
+ Hits         8169     8183      +14     
- Misses       1387     1388       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 04 '25 17:05 codecov[bot]

Thank you @AgnieszkaZaba and @erosky

This PR addresses:

  • #1554
  • #1321

Kudos!

It introduces:

  • #1588

The only change, I'd suggest to add before merging is at least minimal coverage for the newly introduced items that seem neither unit-testsed nor used in any of the examples:

  • the Fick class (perhaps just add to tests/unit_tests/physics/test_drop_growth.py?)
  • the BolotEtAl2013 class (add a test to tests/unit_tests/physics/test_isotope_kinetic_fractionation_factors.py or maybe leave it for a separate PR?)

slayoo avatar May 17 '25 12:05 slayoo