Sylwester Arabas

Results 518 comments of Sylwester Arabas

> > However, this made me wonder: why are the number of SDs decreasing with time initially even in the no seeding case? > > This is a good question......

> I see your point, @slayoo . I have now removed the update step for `cell id` etc. but still continue to see the same issue of the whole buffer...

> @slayoo I verified the increase in super-droplet count by calculating the total number of super-droplets for each simulation timestep in the 1D example. The count starts at 2336, reduces...

@jtbuch, not necessarily related to the sd-count-per-cell issue, but it seems that as of now: - position attributes of seed droplets are initialised to zeros - the `Displacement` dynamic still...

as for the SD-count jumps, I'm inclined to blame the incompatibility of seeding with the `cell_start`-computing logic here: https://github.com/open-atmos/PySDM/blob/36811d9629559f9e990317196130b63de0fd792d/PySDM/backends/impl_numba/methods/collisions_methods.py#L685-L697 We need to start with writing a unit test for multi-cell...

logic for computing advector field from momentum scalar fields and extrapolating it in time to t+1/2 would be part of it

@bsumlin, it would be great to merge this PR to address #25

Thank you! Let me take the liberty to also ask for a PyPI release of the updated code, thanks!