PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

move array instantiation from `_impl` to `register()` in physics.products

Open AgnieszkaZaba opened this issue 1 year ago • 3 comments

  • [ ] check files in physics.products

AgnieszkaZaba avatar Dec 09 '24 14:12 AgnieszkaZaba

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.53%. Comparing base (b49a21d) to head (3ff3db5). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage   85.53%   85.53%           
=======================================
  Files         396      396           
  Lines        9601     9601           
=======================================
  Hits         8212     8212           
  Misses       1389     1389           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 09 '24 17:12 codecov[bot]

Hmm... it seems that this change was committed straight to main here: https://github.com/open-atmos/PySDM/commit/16f2f99ee1e9266c7cfe9c60dc255cef445146c3

Still, test would be needed, keeping open

slayoo avatar Dec 26 '24 12:12 slayoo

Stale pull request message

github-actions[bot] avatar Mar 26 '25 13:03 github-actions[bot]