Sylwester Arabas
Sylwester Arabas
@jbarr444, big thanks for this PR! Please stay tuned for an update here
> refactor: should all attributes that concern the shape of the particle (area, volume, capacity for deposition, reynolds number and more...) be handled by particle_shape_and_density? Yes!
Thank you @emmacware
The offending line is here: https://github.com/open-atmos/PySDM/blob/de03b04af6dba7bda31cf3d8061e47dcb1fc1a99/PySDM/products/impl/rate_product.py#L34 This zeroing should be moved into `notify()`
as of now, we have the following failures on CI: - macos-14 (i.e., Apple Silicon): test_hdf5 & test_formats - macos-12 (i.e., Intel): test_hdf5 The test_hdf failure is: ``` 112/214 Test...
Duplicate of #1883 and could be related with: #1899?
> @slayoo https://github.com/gnudatalanguage/gdl/pull/1904 shows NO ERRORS on macos-12 (when did you see an error ?) Yesterday's `macos-12` build for the `master` branch has `test_hdf5` failed: https://github.com/gnudatalanguage/gdl/actions/runs/11681438801/job/32526479047 ``` % TEST_HDF5_BYTE_ARRAY: NO...
Thank you for reporting, @liamgumley! It seems that despite depending on libhdf5-dev (https://salsa.debian.org/debian-astro-team/gnudatalanguage/-/blob/master/debian/control?ref_type=heads#L18), Debian package does not build HDF5 support in GDL (https://salsa.debian.org/debian-astro-team/gnudatalanguage/-/blob/master/debian/rules?ref_type=heads#L27) @olebole, is it something related to this:...
Thanks @olebole !
Thank you! Other relevant issues worth mentioning here: - #1428 - #1203 - #1152