Sylwester Arabas

Results 518 comments of Sylwester Arabas

here's a new issue to track the PyPI release topic in an open ticket: https://github.com/bsumlin/PyMieScatt/issues/29

codecov is done only with JIT disabled, hence threading is also disabled

moving to "Ideas for new features and examples" wiki page

OK, in the 2D kinematic setup, the reuse logic is enabled by default: https://github.com/open-atmos/PySDM/blob/20c83400c8954148579efb1659cf8a0e3a96f758/examples/PySDM_examples/Morrison_and_Grabowski_2007/common.py#L32

IIUC, with the reuse disabled, we are shuffling all `n_sd` numbers regardless of how many are actually needed in a given substep. So, I'd suggest that before removing the reuse...

https://github.com/OguzhanBerkeOzdil/PyMPDATA_project/pull/3

@jbarr444, the key prerequisite for any PR is a unit test. Here, we have the table from the paper that can serve as a source for expected values. We use...

Thank you @jbarr444 To make the test run on CI, we need to first address the code-quality issues raised by pylint: ``` ************* Module PySDM.dynamics.collisions.collision_kernels.hall PySDM/dynamics/collisions/collision_kernels/hall.py:1:0: C0114: Missing module docstring...