Sylwester Arabas
Sylwester Arabas
> * [ ] Look for other places where such functions are defined > * [ ] Look into replacing interpolate in other places, such as `Shipway and Hill (2012)`...
> It seems that, according to ``numba`` docs, the argument ``axis`` in ``np.diff`` is not supported. IIUC, usage of `np.diff` is anyhow out of question here as it allocates new...
@Sfonxu (as we talked about it today), the key issue here is that without the change the code would not work, but the change is in a conditional branch that...
after logging in to the CI worker, it seems that no mp4 file is produced :( ``` runner@fv-az1280-241:~/work/PySDM/PySDM$ ls /tmp/pytest-of-runner/pytest-0/test_run_notebooks__home_runne1/output/ last_animation_frame.pdf sd_attributes_num0000000348.vtu sd_attributes_num0000000720.vtu sd_products.pvd sd_products_num0000000360.vts sd_products_num0000000732.vts sd_attributes.pvd sd_attributes_num0000000360.vtu sd_attributes_num0000000732.vtu sd_products_num0000000000.vts...
to sum up: - currently SaveAnimatuon is called with an .mp4 filename and it silently does nothing causing CI failure - let's try changing all occurences of `.mp4` to `.avi`...
browsers do not support AVI well.... let's generate .ogv and confert it to .mp4 on CI...
closing & reopening to trigger CI
@olastrz, ogv->mp4 conversion and all uploads seem to work OK! The last remaining issue is that the animation is seemingly incompletely rendered, here's how the uploaded artifact looks like: ...
@olastrz, the animation now works on macos-13, but the output file is exactly the same as on Linux - white on gray without multiplicity scale: https://github.com/open-atmos/PySDM/actions/runs/14957602401 Could it be a...
kudos @AgnieszkaZaba for solviong the mystery!!! (it was the version of `pyevtk` that PySDM uses for vtk file output, and which was pinned on CI to an older buggy release)....