PyMPDATA icon indicating copy to clipboard operation
PyMPDATA copied to clipboard

rust hello world

Open Sfonxu opened this issue 1 year ago • 1 comments

Sfonxu avatar Sep 06 '24 12:09 Sfonxu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.02%. Comparing base (1c08c32) to head (5e02de1). Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 06 '24 13:09 codecov[bot]

@Sfonxu, the CI build now fails with:

Error:   --> src/main.rs:43:60
   |
43 |     let stepper_arg = vec![("options", options),("n_dims", 2)].into_py_dict_bound(py);
   |                                                            ^ expected `Bound<'_, PyAny>`, found integer
   |
   = note: expected struct `pyo3::Bound<'_, PyAny>`
                found type `{integer}`

slayoo avatar Oct 21 '24 19:10 slayoo

As to comment on changes made to readme_rust.yml file:

  • changed python toolchain version to v5
  • changed rust toolchain to dtolnay/rust-toolchain@stable This seems to have worked and successfully compiled the rust example

Sfonxu avatar Oct 24 '24 17:10 Sfonxu

kudos @Sfonxu ! Mergin, but also adding a new issue: https://github.com/open-atmos/PyMPDATA/issues/469

slayoo avatar Oct 24 '24 20:10 slayoo