Sylwester Arabas

Results 518 comments of Sylwester Arabas

this might help: https://github.com/flatpak/flatpak-github-actions

> lgtm Thanks for the reminder. I'd say that this is not really mergeable "as is" because of other instances of this requirement in the repo: - https://github.com/open-atmos/PySDM/blob/64877edd954f369e26160ebe74c0c4d90c1b5361/setup.py#L47 - https://github.com/open-atmos/PySDM/blob/64877edd954f369e26160ebe74c0c4d90c1b5361/.github/workflows/readme_snippets.yml#L28...

ideas to explore: - [ ] colouring isotopic content using (R,G,B,A) for (HDO, H2_18O, H2_17O, H2) (not necessarily from 0 to 1 in intensity) - [ ] try adding a...

perhaps we could use pre-commit hooks to enforce it, e.g., using https://github.com/streetsidesoftware/cspell-cli

IIUC, this is what is already done in the Debian packaging workflow: https://sources.debian.org/patches/gnudatalanguage/1.1.1-1/Create-a-shared-library.patch/

> [@slayoo](https://github.com/slayoo) I wonder why such patches from our dear distro maintainers are not systematically retrofitted in the master code... @olebole did propose it as a patch back 10 years...

@tbeu, @jhendersonHDF, we're encountering build failures on Github Actions with the very same error messages. Are there any updates here? Thanks!

Thanks for the follow ups. We've ended up with this addition in CMakeLists.txt to workaround it: ```CMake if (MINGW) # https://github.com/HDFGroup/hdf5/issues/5885 target_compile_definitions(hdf5-static PRIVATE _GNU_SOURCE) endif() ```