Patrick Ohly
Patrick Ohly
Also relevant here is the ordering. At the moment, the following creates the new "proxy" participant to the very far right: ``` sequenceDiagram participant apiserver box kubelet participant plugins as...
Let's fix the linter issues first, see https://github.com/kubernetes/klog/pull/402
I don't have a strong preference here and could live with just having `Error(nil, ...)` myself. No idea for a better name.
Also note the build failure: ``` pkg/controller/nodeipam/ipam/cloud_cidr_allocator_nolegacyproviders.go:31:35: undeclared name: klog ```
/lgtm /assign @soltysh Thanks for keeping the PR up-to-date. We should be able to get it merged soon.
/assign @dims For approval in cmd/cloud-controller-manager.
No progress on https://github.com/kubernetes/kubernetes/pull/102025 but as I think that that's the right solution I'll close this one here. /close
Oh, I had forgotten about this PR and did my own with the same logtools update. The errors are keys in existing code that violate our guidelines and now trigger...
This would be useful for [a more precise suppression of a goroutine in Kubernetes](https://github.com/kubernetes/kubernetes/pull/115456#discussion_r1094960760) which is currently reported as being in `time.Sleep`.
/reopen Some preparatory work is being done in https://github.com/kubernetes/kubernetes/pull/121394