Patrick Ohly
Patrick Ohly
Update: waiting for log/slog in Go 1.21 IMHO was worthwhile. Instead of adding a new special `logr.KeysAndValues`, we can instead use [`slog.GroupValue`](https://pkg.go.dev/log/slog#GroupValue) and the `LogValue() slog.Value` method. Support for those...
/unassign thockin /assign
The following PRs are ready for merging, if we agree on the approach: - https://github.com/go-logr/zapr/pull/56 - https://github.com/kubernetes/kubernetes/pull/121984 TODO: klog text format
/remove-lifecycle rotten ping @tallclair: still interested?
Your suspicion seems correct to me (not an expert, I just stumbled over this for [other reasons](https://github.com/kubernetes/autoscaler/pull/6122)): https://github.com/kubernetes/autoscaler/blob/f9a7c7f73facc4baba7189bc6ab5c4e0e77cfee1/cluster-autoscaler/utils/drain/drain.go#L187-L197
Some patches can be found here: https://yrh.dev/blog/remote-editing-go-code-with-emacs/
/remove-lifecycle rotten
/remove-lifecycle rotten I was looking for a volunteer to continue with this, but so far without luck. I'll probably finish this myself.
@bells17: help with this would be very welcome. Feel free to take my branch, rebase it and continue in a new PR. I think with this PR and https://github.com/kubernetes-csi/node-driver-registrar/pull/259 it...
I saw a comment on #sig-testing that folks are moving away from trivy because it generates too many false positives. The main problem is that it doesn't consider which code...