Patrick Ohly
Patrick Ohly
https://github.com/kubernetes/kubernetes/pull/120750 is getting cherry-picked in: - 1.29: not needed (was included) - 1.28: https://github.com/kubernetes/kubernetes/pull/122580 - 1.27: https://github.com/kubernetes/kubernetes/pull/122581
Do we want to backport [golangci-lint v1.55.1](https://github.com/kubernetes/kubernetes/pull/121476) or just bump up honnef.co/go/tools to v0.4.6 on older branches?
release-1.29 is already on golangci-lint v1.55.1 and thus honnef.co/go/tools v0.4.6. release-1.28 and older aren't. When bumping only honnef.co/go/tools v0.4.6 together with `.go-version`, linting passed on [release-1.28](https://github.com/kubernetes/kubernetes/pull/123768) and [release-1.27](https://github.com/kubernetes/kubernetes/pull/123769). Code gen...
I have it on my TODO list, but it may take a while before I get to it.
This might be a reasonable addition. What API did you have in mind for creating such a struct?
We cannot change `KRef`, changing its behavior would be unexpected for some users. `KResourceRef` sounds good to me. If you want to give it a try, feel free to prepare...
/unassign I don't have time to drive this.
/remove-lifecycle rotten
/cc /remove-lifecycle rotten Shouldn't this issue be over in k/k? That's where the code gets developed.
Let's merge this. /lgtm