Patrick Ohly
Patrick Ohly
> I have duplicates of the key key with different values which makes the field useless. I'm not so sure about this. My understanding of the "repeated key" semantic is...
Right now you can't. As you noticed, logr doesn't have a concept of "more important than INFO = V(0)". Introducing such a concept would be a breaking change (LogSinks don't...
> Every library would fight to be even more important than every other library. [...] A major part of the design was to bound what a library can emit. I...
That works if the bias is inside the code which does the log call. It does not work when code in package A is calling function `DoSomething(logger logr.Logger, ...)` in...
This works as expected and does indeed help with watching progress in Prow. Thanks! I think this can be closed.
I went through the proposal. Lot's of useful stuff, thanks for considering this change. I left one comment (just for clarification), the proposal itself looks good to me.
Can we do both? Option 2 may be useful for users to quickly try out the effect of the CLI flags. Option 1 can be achieved by not setting any...
So you mean a process can invoke either `PreviewSpecs` or `RunSpecs`, but not both (i.e. first `PreviewSpecs`, then `RunSpecs`)? The `-list-tests` and `-list-labels` that I am implementing in https://github.com/kubernetes/kubernetes/pull/112894 would...
Excellent! I'll take a look.
I've now also tested with `PreviewSpecs` followed by `RunSpecs`. Everything is working as expected, so as far as I am concerned, this is ready for tagging a release.