Patrick Ohly
Patrick Ohly
/assign @mrbobbytables For approval.
/remove-lifecycle stale
/remove-lifecycle stale /assign @liggitt
It is a bit annoying that Go doesn't properly support "cause" in all variants of the context.With* calls. As it stands now (Go 1.21), one has to re-implement context.WithTimeout to...
The klog text output currently checks for `error` first and then logs the message from `Error`. Changing that is not hard: ```patch diff --git a/internal/serialize/keyvalues.go b/internal/serialize/keyvalues.go index ad6bf11..33813b4 100644 ---...
Perhaps we can log both with separate keys: - "err": `` - "errObject": `` To achieve what @tallclair originally asked for (providing additional key/value pairs) we could add a new...
>funcr has `PseudoStruct` which is similar to what you are describing. I did it in funcr because it felt kind of dirty to try to push that into every sink....
I implemented logging a "structured error" as "err" + "errDetails": - https://github.com/go-logr/zapr/pull/56 - https://github.com/kubernetes/klog/pull/359 - https://github.com/go-logr/logr/pull/164 This is work in progress (lacks some unit tests, depends on release of logr...
That's correct. One caveat is that there's no consensus yet on the `logr.KeysAndValues` type.
/remove-lifecycle rotten