kubernetes
ktesting: tone down warning about leaked test goroutine
What this PR does / why we need it:
Not terminating immediately is fairly normal: many controllers log "terminating" messages while they shut down, which often is right after test completion, if that is when the test cancels the context and then doesn't wait for goroutines (which is often not possible).
Therefore the warning now only gets printed if that happens after more than 10 seconds since test completion, and then the warning is only printed as an info message, not an error.
Release note:
ktesting: the warning about leaked goroutine is only shown after 10 or more seconds and is no longer an error message.
/cc @aojea @soltysh @kerthcet
This issue is currently awaiting triage.
If klog contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Let's fix the linter issues first, see https://github.com/kubernetes/klog/pull/402
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kerthcet, pohly
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [pohly]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/assign @dims
For approval. A new release for Kubernetes 1.31 also makes sense.
Hmm, we want a few more things for a new release, like https://github.com/kubernetes/klog/pull/404
/retest
Does that work for GitHub actions? The linter wasn't happy, for some reason.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aojea, dims, kerthcet
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dims]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment