Patrick Ohly
Patrick Ohly
/assign @geetasg
/test pull-kubernetes-dra-integration
Please rebase, perhaps the warning because of `newTLSConfigCopy.NameToCertificate` then goes away.
The warning about `newTLSConfigCopy.NameToCertificate, err = c.BuildNamedCertificates(ctx, newContent.sniCerts)` is genuine, you are touching that line (adding the `ctx`). But as you are not changing the logic around `NameToCertificate`, I suggest...
I think we need to discuss further what kinds of metrics are desirable before we merge this. For example, the duration could depend a lot on the driver, so having...
> In any case, after changing metric type to the HistogramVec it can be added any time. Wouldn't it be better to design this metric so that we don't need...
> The main purpose of this PR is to bring DRA latency under control to prevent its uncontrolled growth. That's what the test is about, right? Let's submit and discuss...
/retest kubetest2 jobs should be fixed now.
I've not had time to review the PR again. I just removed the hold because my request to clarify the driver name label seemed resolved. /hold To prevent merging in...
/hold cancel