Patrick Ohly

I'm not sure about this. How would code know that it is okay to pass a `json.RawMessage` as a value? This is only useful in code which will only ever...

> That's why this is in the funcr specific code that is logging in JSON format. It's scoped directly to that and not in the general case on purpose. Let...

> There is, however, a chance that a given After* node will hang so Ginkgo needs to keep an eye on things and make sure that the After* nodes finish...

> I tend to agree, and as I said somewhere (not sure anymore where), Kubernetes should have timeouts defined pretty much everywhere, so this works for us. However, those are...

It's also hard to review how long the entire spec is expected to run. One would have to sum up the individual timeouts, of which most are hidden behind helper...

> I wish I could forcibly end the go function. But that isn't possible. That's what I thought. > It just moves on to other things (so you actually potentially...

That makes sense. However, I am now worried about the following situation: - An `It` node is running when the suite times out. It keeps running because ginkgo cannot kill...

> So, yes, the It may still be running while the After* are running. It might be worth calling that out as a caveat in the documentation, if it's not...

> this actually isn't possible - there's no way for By/GinkgoWriter/Gomega to know whether or not they are running in an It or in an AfterEach Isn't it so that...

> IMO the cost of explicitly not cleaning up if a spec is misbehaving/stuck seems higher to me than the cost of cleaning up concurrently. I'm not planning on changing...