Patrick Ohly
Patrick Ohly
@guilhem: are you still interested in finishing this PR?
After looking at this again, I started to wonder whether this current change goes far enough. There are other controller calls, for example in https://github.com/kubernetes-csi/csi-test/blob/master/pkg/sanity/node.go#L69. If we merge this, can...
> I resolved multi port scraping problem to use exporter that merged any ports. > https://github.com/rebuy-de/exporter-merger Please correct me if I'm wrong, but that only works as long as the...
I tried `proot`. It seems to break the ability to run restic as non-root with additional capabilities (https://restic.readthedocs.io/en/stable/080_examples.html#full-backup-without-root); at least I got `scan: Open: open /.pulse: permission denied` errors that...
> What makes this feature so hard to implement? Speaking as a developer myself (not of restic, but other open source projects): it's often not the complexity of a feature...
I guess this is about preventing incorrect log calls like `logger.Info("hello world", "missingvalue" /* , 42)`. @lpar: both logr and slog are using linters to catch malformed key/value parameter. For...
I had considered this. It seems doable. I did not pursue it further because it won't work with current LogSink implementations. If we expect implementations to be modified, wouldn't it...
The alternative is an interface that is specific to slog: ``` // SlogSink is an interface that a LogSink can implement to support logging // through the slog.Logger or slog.Handler...
Here's a comparison of all benchmarks between master (b3dc695bce6838cb3f27ac700c1017947bc3235b) and this PR: ``` name old time/op new time/op delta pkg:github.com/go-logr/logr/benchmark goos:linux goarch:amd64 DiscardLogInfoOneArg-36 95.6ns ± 4% 99.7ns ± 4% +4.31%...
> I prefer the first model, myself. The main advantage of pushing this down to the Sink is that the ContextKeys don't get copied? I redid the performance comparison after...