community icon indicating copy to clipboard operation
community copied to clipboard

guide: Add more docs around tide/merge-method-squash

Open MadhavJivrajani opened this issue 2 years ago • 18 comments

This commit adds more information about the label tide/merge-method-squash and shows what the commit message ends up looking like if the label is used on multiple commits, especially if the PR contains fixup commits like "address reviews".

Adding this documentation to better illustrate the effects of using this label as opposed to squashing by hand and preserve good commit message practices.

Some slack context here /sig contributor-experience

MadhavJivrajani avatar Mar 09 '22 08:03 MadhavJivrajani

/assign @nikhita @parispittman

MadhavJivrajani avatar Mar 09 '22 08:03 MadhavJivrajani

@palnabarun

Thanks for adding this explanation! The content looks good.

I had a different nit. Since we are duplicating the exact text in two different documents, can we write the directive in one document and provide a reference in the other document? I am wary of the content diverging in future.

I'll retain the content in pull-requests.md and reference it in contributor-cheatsheet?

MadhavJivrajani avatar Mar 09 '22 09:03 MadhavJivrajani

I'll retain the content in pull-requests.md and reference it in contributor-cheatsheet?

That makes sense to me. 👍🏽

palnabarun avatar Mar 09 '22 09:03 palnabarun

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MadhavJivrajani To complete the pull request process, please ask for approval from nikhita after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 09 '22 09:03 k8s-ci-robot

/retest (pod timed out)

MadhavJivrajani avatar Mar 09 '22 10:03 MadhavJivrajani

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 08 '22 13:06 k8s-triage-robot

/remove-lifecycle stale

pohly avatar Jun 08 '22 15:06 pohly

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 06 '22 15:09 k8s-triage-robot

/remove-lifecycle stale

imnmo avatar Sep 07 '22 03:09 imnmo

This Guide is still useful for new contributors and reduces friction to contribute.

imnmo avatar Sep 07 '22 03:09 imnmo

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 06 '22 04:12 k8s-triage-robot

/remove-lifecycle stale

pohly avatar Dec 06 '22 06:12 pohly

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 19 '24 23:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 18 '24 23:02 k8s-triage-robot

/remove-lifecycle rotten /test all

cblecker avatar Feb 19 '24 00:02 cblecker

/easycla

cblecker avatar Feb 19 '24 00:02 cblecker

Let's merge this.

/lgtm

pohly avatar Feb 22 '24 12:02 pohly

/assign @mrbobbytables

For approval.

pohly avatar Feb 23 '24 10:02 pohly