Patrick Ohly

Results 1004 comments of Patrick Ohly

@divyenpatel, @msau42, @jsafrane: do you remember why the flag was left at default false in https://github.com/kubernetes-csi/external-provisioner/pull/516? Is it because that would have changed the default behavior and that wasn't desirable?...

This is the gist of it. Note that we haven't actually verified that a newline will help, but it seems likely. While you are at it, a mode where not...

Or make it so that just the `S` gets skipped (pun intended). The `o` is useful when running a few tests.

It is a bit annoying that Go doesn't properly support "cause" in all variants of the `context.With*` calls. As it stands now (Go 1.21), one has to re-implement `context.WithTimeout` to...

Sounds like a useful thing to do. However, I have very little experience with Prow source code, so it would be better to get confirmation from someone who knows it...

I'm aware that Gomega usually cannot log anything when using the global instance (= `gomega.Eventually`). When using `gomega.NewWithT`, it would have been possible to require `T.Log` method, but currently [GomegaTestingT](https://pkg.go.dev/github.com/onsi/[email protected]/types#GomegaTestingT)...

It is primarily “I am actively running a test". I know that I can send SIGINFO, but that produces more information than I need. My main motivation is "tell me...

I would: - Completely strip the file path: `./foo/foo.so` -> `foo.so`. Otherwise re-creating the existing path elsewhere becomes awkward. - Treat `GOLANGCI_LINT_CUSTOM_PLUGIN_PATH` like `PATH` in a shell and support multiple...

I was pinged again about this because it's still unsolved for containerized Kubernetes builds. Any preference on how to solve this? I'm leaning towards falling back to PATH when some...