Patrick Ohly

Results 1004 comments of Patrick Ohly

The problem that I had to solve here is that the content of a `topology.Segment` is a slice, and slices cannot be used as keys in a Go map. The...

> The segments are all returned from c.topologyInformer so I don't believe they will have the same address even if they represent the same segment. `c.topologyInformer` should keep segment pointers...

I've proposed an implementation based on `not-path` instead of `notpath` (hyphen for readability) in https://github.com/golangci/golangci-lint/pull/3617.

Is there anything that can be done about this on a per-linter basis? In https://github.com/nunnatsa/ginkgolinter/issues/63#issuecomment-1439726442 it was pointed out that for some linters, fixing already works.

/remove-lifecycle stale /lifecycle frozen

Looks like I need `work_state_1` after all. The inverter is down again, with: ``` vr001 run_state ON 5038 work_state_1 None 5081 work_state_2 None ```

I power cycled the inverter. Now I get something other than `None`: ``` vr001 run_state ON 5038 work_state_1 Run 5081 work_state_2 Stop ``` So it looks like it's only the...

I also need something like this for Kubernetes. I am[ removing the usage of certain functions](https://github.com/kubernetes/kubernetes/pull/112923) from test/e2e* directories inside the main Kubernetes repo because they don't accept a context...

See https://github.com/ashanbrown/forbidigo/pull/22 for a proposed solution.

Can you also do pkg/controller/endpoint, pkg/controller/garbagecollector, pkg/controller/nodeipam, pkg/controller/replicaset, pkg/controller/statefulset, pkg/controller/util, pkg/controller/volume? That can be a single cleanup PR because those components were already converted earlier.