Phillip Webb

Results 467 comments of Phillip Webb

The following ugly hack will work with 3.3.x: ```java package com.example.demo; import java.util.List; import org.springframework.boot.devtools.restart.RestartScope; import org.springframework.boot.test.context.TestConfiguration; import org.springframework.context.annotation.Bean; import org.springframework.test.context.DynamicPropertyRegistry; import org.testcontainers.containers.ContainerState; import org.testcontainers.containers.GenericContainer; import org.testcontainers.lifecycle.Startable; import com.github.dockerjava.api.command.InspectContainerResponse; @TestConfiguration(proxyBeanMethods...

Flagging to see if the team think we should still attempt a fix in 3.2/3.3.

We're going to leave this one open to see if we can fix it in some way, but it's hard to see us getting to it quickly. Upgrading to 3.4....

@shawnweeks I think the issue in the sample is the `demoFilter` bean is causing early initialization. This is a general problem, not just related to Testcotnainers. There's a [small warning...

I'm sorry @Wzy19930507 but I don't have time to actually look into this one right now. Feel free to have a go at fixing it if you like, but I...

I think we ended up manually testing the fix for #37989, I'd like to see if we can an actual integration test that fails the build if we accidentally reintroduce...

@LightGuard No update I'm afraid, it's still on the TODO list.

I don't like adding this directly to `SpringApplication` but perhaps we could promote a pattern more like this: ```java private class MyApp implements BeanRegistrar { @Override public void registerBeans(BeanRegistry registry)...

Dropping the annotation model entirely opens another can of worms. We'd need to consider component scanning, the JPA base package stuff and how to do excludes. We'd also need to...

Fixing this means we'll also probably want to change the default context to not be an `AnnotationConfigApplicationContext`. See #14590 for details.