Phillip Webb

Results 467 comments of Phillip Webb

Checking if `CapturedOutput` contains a string causes test to hang

Could you please attach a sample project that we can download and run. The snippets are helpful, but a full project with a build file will be better to ensure...

Checking if `CapturedOutput` contains a string causes test to hang

Also, if you can replicate this in Java that will be even better as there's one less moving part.

Checking if `CapturedOutput` contains a string causes test to hang

I think we should add some caching to `org.springframework.boot.test.system.OutputCapture` so that repeated calls are faster.

Replace our TestCompiler with Spring Framework's version

We pretty much only use qdox now to get the fully-qualified class name. I think we could probably replace it with our own parser if we wanted.

Harmonize AOT goal/task names

At least for now we're going to go with... Maven: ``` spring-boot:process-aot spring-boot:process-test-aot ``` Gradle: ``` bootProcessAot bootProcessTestAot ```

Update SpringBootContextLoader to return prepared but not refreshed contexts

Work is ongoing for this in https://github.com/philwebb/spring-boot/tree/gh-31965

Support .env file for configuration properties

@petromir not really I’m afraid. We’re currently investing most of time on other issues. I suspect it might take a while for us to get to this one.

@ComponentScan on a test class is processed when creating a test context but is not included in the context's cache key

We're going to try and support `@ComponentScan`. We'll update `ImportsContextCustomizerFactory` to detect it and `ImportsContextCustomizer` to include it as part of the cache key.

Adapt to Spring Session Data Redis switching to an unindexed repository by default

We're not going to add a property to switch the implementations. If users want the indexed version then they'll need to configure it themselves.

Apply 'server.max-http-header-size' consistently across all servlet containers

We discussed this today and we'd really like to align things if possible so that the property is just used for the request header. @markt-asf would an enhancement to Tomcat...