Phillip Webb

Results 467 comments of Phillip Webb

Perhaps we can add a dependency in `spring-boot-starter-oauth2-client` to `spring-boot-starter-json` since JSON is needed most of the time?

I think the use of `JoranConfigurator` is indeed the problem, but I'm not convinced that we should make `SpringBootJoranConfigurator` public. Programmatically refreshing the logging system isn't something we've considered supporting.

We discussed this today at our team meeting and decided that we'd prefer to keep `SpringBootJoranConfigurator` package private. Programmatically refreshing the logging system isn't something we can prioritize at the...

This is a little counter intuitive, but is actually an intentional design decision. We don't want to apply the properties to the `Environment` until they have all been loaded. Having...

The documentation isn't great in this area, but I don't think the problem has been raised before. I'd keep the workaround out of the documentation since it looks a little...

Thanks @donat! This commit did the trick for us https://github.com/spring-projects/spring-boot/commit/13d00d85e0f1af49356ea19fe7ec09cce74975a3

> I don't have anything else to add. Maybe @philwebb might. Sorry, not off the top of my head. The bootstrap logic is always quite difficult to get right.

Thanks for the offer @madanhk18, but this one will require a little design work so we aren't ready to accept contributions just yet.

In the meantime I've suppressed all warnings. We'll need to revert the following at some point: * 02ee7fdb3013d19cf33618318a37ed290a23ea76 * 379b2ceb56ac740d4f4ffc4d58db470f2eb383ac * 42d0f7216bf01ac5082aae1af2c9c706618d219e