Phillip Webb

Results 467 comments of Phillip Webb

Hi @itsAkshayDubey, any luck implementing the requested changes?

I personally prefer to avoid aspects when at all possible, but the event idea sounds quite nice to me.

Closing in favor of PR #42073. Thanks @nosan!

Since this is quite an edge-case I think a new annotation might be better. I'm worried that more attributes on `@ConfigurationProperties` might be confusing. We already have `@NestedConfigurationProperty` so perhaps...

We discussed this today and we'd like to configure this in an external file (similar to `additional-spring-configuration-metadata`). This would remove the need for any new public annotations. We'd keep the...

@brabenetz I was under the impression that with filter out properties that only have a setter unless they are collections or nested properties. [This line of code](https://github.com/spring-projects/spring-boot/blob/6500c8458ef0e6a8080fb90367b5a05952c80d49/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/JavaBeanPropertyDescriptor.java#L80) should do that....

We discussed this again today and given https://github.com/spring-projects/spring-boot/issues/2421#issuecomment-2607051846 we want to put the filter data inside the existing `additional-spring-configuration-metadata.json` _and_ have it copied to the generated `spring-configuration-metadata.json`. We'll also use...

Moving to 2.0.x is fine I think if we can't easily fix this in 1.5.x

I thought I'd fixed it previously. I'm not sure why it stopped working.

Thanks for the detailed analysis @nosan. This is indeed a complicated issue to fix and made even more difficult by the changes we're introducing in 3.4 due to #41996. I'm...