spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Add Testcontainers at development time integration test

Open philwebb opened this issue 2 years ago • 5 comments

Ideally we should have a test that catches issues like #37989

philwebb avatar Oct 25 '23 18:10 philwebb

Hi, @philwebb may i join this task?

Wzy19930507 avatar Oct 26 '23 01:10 Wzy19930507

I'm sorry @Wzy19930507 but I don't have time to actually look into this one right now. Feel free to have a go at fixing it if you like, but I won't be able to provide much guidance at the moment.

philwebb avatar Oct 26 '23 04:10 philwebb

Hi, @philwebb Because of server need start before client get server metadata(such as ip/port), i need prove that call Container.start before create client bean.

Case to be verified that create client bean after BeanPostProcessor

  • LoadTimeWeaverAware
  • @Configuration
  • ApplicationRunner

But is this feasible?

Wzy19930507 avatar Oct 28 '23 15:10 Wzy19930507

@philwebb I think this issue can be closed due to has been properly tested in #37989, right?

eddumelendez avatar Jul 05 '24 05:07 eddumelendez

I think we ended up manually testing the fix for #37989, I'd like to see if we can an actual integration test that fails the build if we accidentally reintroduce the problem.

philwebb avatar Jul 22 '24 08:07 philwebb