Phillip Webb

Results 467 comments of Phillip Webb

Thanks mark, I've opened https://bz.apache.org/bugzilla/show_bug.cgi?id=65866

Digging into this a bit today and the fix for #29356 has caused the regression. The `NoClassDefFoundError` is actually caused by `JarFile.ensureOpen()` throwing an `IllegalStateException`. It looks like `java.util.zip.ZipFile$CleanableResource$FinalizableResource` is...

@ayashkov Thanks so much for putting the sample application together, it was really helpful!

I've pushed something that I hope will fix this but I'm not totally confident. If it doesn't work we may well need to revert the fix for #29356. We're planning...

Unfortunately we're now facing file locking issues on Windows again. I'm going to revert the fix for #29356

Interesting, I wonder if we might find a few more of those.

We're probably not going to be able to customize the `ErrorReportValve` because `valve.setProperty` requires a file and that won't work with fat jars. We'd like to investigate a little more...

@gaurav-91 Thanks for the offer to help, but would you mind not commenting on multiple issues. It sends email notifications to everyone watching the issue tracker. If you're new to...

I wonder if this might also be related to `SpringApplication.allowBeanDefinitionOverriding` which we added in 2.1.

For "1)" the `@NestedConfigurationProperty` could be the indicator that the value isn't a scalar. So `@NestedConfigurationProperty Map` is a hint that `Foo` can be expanded with the `*` syntax, where...