Phillip Webb
Phillip Webb
Thanks @nosan. We're going to wait for 3.5 to merge this one. The version bump is a bit risky post RC
No it's fine. We'll just deal with that nearer the time.
We're not totally sure yet. I've added the "pending design work" label to make it clearer that we're not ready to accept contributions yet for this one.
I like `YamlPropertySourceFactory` since it's quite obvious what it does. Once thing that makes me pause is that we don't/can't support `spring.config.activate.on-profile` for multi-document files. We also can't support `spring.config.import`....
Perhaps we should make it a hard requirement that only a single document is in the YAML and that no profile restrictions or imports are specified. We'll discuss this on...
I'm wondering if basic YAML support should be something that's added to Spring Framework. Perhaps with some hook point so that we can warn if users accidentally point at YAML...
> What kind of hook point did you have in mind, and who would hook into that? If you added some kind of YAML support, we could have a `spring.factories`...
Thanks @nosan, we discussed this one today and we agree that closing it is the best course of action for now.
Thanks @quaff, We'll probably wait until the restructuring work is done before we look at merging this one so it might be a while before we get to it.
@sjohnr We have `@@ConditionalOnNotWebApplication` but it looks like [`FreeMarkerNonWebConfiguration`](https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/freemarker/FreeMarkerNonWebConfiguration.java) is the only configuration that uses it.