Phillip Webb

Results 467 comments of Phillip Webb

We like the idea of at least logging the application name, if we can do it without adding too much noise.

It's unfortunately hard to come up with a general rules for these that we can enforce. In some cases (like this one), I like the proposed change. In others, I...

- See https://github.com/spring-projects/spring-boot/issues/42591 for background

> is there a particular driver for submitting this PR for the 6.1.x branch? Nothing other than I considered it a bug so I thought an earlier branch might be...

@jhoeller Rebased to `main` and forced pushed. I've aligned with the JDK code as best I can, but it's unfortunately pretty hard to test this stuff.

@juliojgd I don't think there are plans to backport due to the risk. See https://github.com/spring-projects/spring-framework/pull/33705#issuecomment-2427305822

See https://github.com/spring-projects/spring-integration/issues/9455 for the original request. We need some more time to consider our options portfolio wide so we'll need to look at this after 3.4

@jgrandja do you have any thoughts on this suggested change?

We discussed this today and we've decided to add the `LazyInitializationExcludeFilter` directly in our auto-configuration. For 4.x we'll try and change the static calls. I've opened #46014 to deal with...

> How can I correctly map kebab-case values? ReadFrom.valueOf supports case-insensitive names (e.g., upstreampreferred). I used readFrom.replaceAll("-", "") I think we can use the same logic as in `LenientObjectToEnumConverterFactory`. I've...