Phillip Webb

Results 467 comments of Phillip Webb

The root cause of this is https://github.com/apache/tomcat/pull/742 and has been fixed in https://github.com/apache/tomcat/pull/745. If you update the sample with `maven { url "https://repository.apache.org/content/repositories/snapshots" }` and use `implementation "org.apache.tomcat:tomcat-jdbc:10.1.29-SNAPSHOT"` then things...

I'm wondering if we should create our own wrapper object for serialization and try to support the `MessageSourceResolvable`. Looking at the code, there's a lot of overlap with the reactive...

We discussed this today and would like to add a wrapper object. This will be a slight breaking change and the Javadoc of `DefaultErrorAttributes` will need to be updated. We'll...

Absolutely @YongGoose, that would be most welcome. We won't be able to merge it for 3.4 but it can be a 3.5 enhancement.

I think this is probably safe, but we need to be a little careful using `List.copyOf`. Unlike `Collections.unmodifiableList(new ArrayList(...))` it will throw an exception if any of the elements are...

@mhalbritter reminded me we've discussed this before as part of #14860

We discussed this today and we think we might be able to pass the `Transport` to a `OtlpTracingConnectionDetails.getUrl(...)` method. We can experiment with this before we merge the PR.

We recently had a performance issue where we thought we might need to add our own `Environment` implementation. If we had done that, then this would be a nice addition...