Petrik de Heus

Results 175 comments of Petrik de Heus

Hi @bluemihai, You can reference my fork by using the following in your Gemfile: ``` gem 'foundation-rails', git: 'https://github.com/p8/foundation-rails.git', ref: '199beb3' # switch to sassc and fixes reveal animation ```...

@parndt Thanks, for the heads up.

I'm using `update-alternatives` on Ubuntu. No need for rbenv. ```Dockerfile # install ruby 3.0 RUN apt-get update -q \ && apt-get dist-upgrade --assume-yes \ && apt-get install --assume-yes -q --no-install-recommends...

Thanks for the review @rafaelfranca. I'll try to fix the issues you mentioned.

> Does this work in production? Because `after_initialize` runs after eager load is run, and eager loading would load all those frameworks, so we would see the warning. Would not...

~~Ok, with eager_load the warning is still shown. I'll need to fix that.~~ Edit: a nevermind. It's working as expected.

We also put the verb first for `reverse_order`, `invert_where`, etc. So maybe `append_select`, similar to `append_around_action`? If we look at existing methods that start with `select_`, We have methods like...

I'm also wondering if it would be more inline with `where/rewhere` and `order/reorder` if `select` would append by default (just like `where` and `order` append) and if you want to...

There also the somewhat related PR for implicit `default_order`: https://github.com/rails/rails/pull/39525 This `order` will be used unless someone overrides it by calling `order`. `select` also has this "implicit default" but it's...

Hi @pinzonjulian, If you used code from @ollieh-m, could you add them as a coauthor in a commit? Co-Authored-By: .... Could you also squash the commits?