Petrik de Heus comments

Results 175 comments of


                                            Petrik de Heus

Fix build and update ruby versions

Ok Ruby 2.1.3 still generates an error. I've removed it from the `travis.yml`

Trigger `reconnected()` callback after reconnects

Hi @mansakondo, I think this is missing an entry to the actioncable/CHANGELOG. Could you create a PR to add it?

Deprecate quoting ActiveSupport::Duration as an integer (#44341)

I think this would still need a [deprecation configuration](https://github.com/rails/rails/blob/82bab92cfe9ab62793cc82d25e6662e4359352e9/railties/lib/rails/application/configuration.rb#L90-L102).

Replaced `<br/>` with `<br>`

Hi @iainbeeston, 👋 Looking at that WhatWG spec it also recommends using paragraphs instead of a `` for separating label and input. That's how it used to be before: https://github.com/heartcombo/devise/commit/b86c1c241b9bc6f6679ff1da78ffda880dd1bf9c...

avoid modify of frozen string in validatable.rb

Hey @mameier, rhis does seem like a valid fix to me. I think commit 2e521bffcd93752cd08c32b41a05e3298b51eb02 is unrelated and should be dropped from this PR. Also I think we need to...

Adding `type: "module"` to actiontext caused an error

With the [retirement of Webpacker](https://mobile.twitter.com/rails/status/1483772667756957699) there won't be any updates to webpacker. I think you might have more luck with its successor: https://github.com/shakacode/shakapacker

Make copying and pasting terminal commands easier

With github's copy button this does seem like a nice change. It seems most Ruby projects still have the prompt. The only example I could find of removing it for...

Change define_helpers parameters to String

Hey @gardnerapp, thanks for contributing to Devise! It seems like passing the mapping instead of the name was changed in: https://github.com/heartcombo/devise/commit/ef841ca17d37040e89072debb1e1d8b5f6726c34 It doesn't seem to be a requirement for the...

Change define_helpers parameters to String

@gardnerapp Sorry, `:nodoc:` means it's not documented as public API. Third parties shouldn't use it because it might change in the future, like the changes in this PR. > :nodoc:...

Unclear how to turn off validations

What are the validation error you are getting? The only validation changes are from ac432977877e22de7db368936d922e81207bf99a I agree we should not have breaking changes with a new release.