Petrik de Heus

Results 175 comments of Petrik de Heus

@ghiculescu Yes, that code is all in sdoc. Older API documentation versions won't get updated though, so changes made will apply to newer versions only. The canonical link should probably...

Thank you @lardawge ! 😄

Thanks for the PR. I'm not sure this would work as expected. What happens if the crop values change? The named variant would not to be updated as well right?

Would it be possible to change the API to be more explicit and less magical? For example yielding the model as well: ```ruby has_one_attached :photo do |attachable, user| attachable.variant :default,...

Inferring the methods is less common I think, and mostly used for the first argument. For most options (including validations, scopes and associations) we allow passing procs instead. I think...

Ah, I see we still support both the following for validations. I thought we were deprecating the first one, but maybe I'm wrong. ```ruby validate :must_have_account, if: :allow_validation # allow_validation...

@rafaelfranca I removed `secrets` in the following PR: https://github.com/rails/rails/pull/49618. There were more changes than expected.

Related: https://github.com/rails/rails/issues/40200

Also wondering if this should be part of: https://github.com/rails/rails/issues/39566

I don't think `rails app:update` should be run when upgrading the tiny version `7.1.2` to `7.1.3`. It just regenerates the config files for `7.1` which includes `new_framework_defaults_7_1.rb`, which don't change...