Petrik de Heus comments

Results 175 comments of


                                            Petrik de Heus

Cookie store configured with domain all, fail for 3-letter domains with a 2-letter TLD

Looking at https://github.com/weppos/publicsuffix-ruby/blob/master/data/list.txt I see for example that both `co.uk` and `caxias.br` are public suffixes. ``` "example.co.uk" =~ DOMAIN_REGEXP && ".#{$&}" => ".example.co.uk" "example.caxias.br" =~ DOMAIN_REGEXP && ".#{$&}" => ".caxias.br"...

Cookie store configured with domain all, fail for 3-letter domains with a 2-letter TLD

Maybe good to pick this up after https://github.com/rails/rails/issues/39566 gets merged.

Implement `button_to` in terms of `form_tag`

Using the existing form tag helpers for `button_to` makes sense to me. Also, form tags like `token_tag` and `method_tag` seem more at place in `FormTagHelper`, especially because they are already...

[DOCS] Warn against uniqueness validator when create_or_find_by is used [ci-skip]

Thanks @sobstel ! Can you squash your commits into a single commit?

[DOCS] Warn against uniqueness validator when create_or_find_by is used [ci-skip]

Thanks @sobstel !

Update some create `has_one` failure test descriptions

Thanks @joshuay03

Add "attribute_for_pretty_print" method

Hi @jordan-brough, thanks for the PR. I've created [similar](https://github.com/rails/rails/pull/40173) PR's before so I see the usefulness of this PR. There is a PR by Rails Core member @matthewd that adds...

Support parameter filtering based on allow lists

Thanks for reviewing this! Enhancing lambdas would be a less drastic change, and I don't think we need to support defining allowed parameters with nested keys like: "credit_card.code" or lambdas...

Support parameter filtering based on allow lists

Hey @jonathanhefner, Found some time to continue with this... The current implementation already does some branching on arity, although this doesn't change behaviour in the branches: https://github.com/rails/rails/blob/f95c0b7e96eb36bc3efc0c5beffbb9e84ea664e4/activesupport/lib/active_support/parameter_filter.rb#L131 Also `ActiveSupport::Notifications.subscribe` will...

Fix override existing join types in the query in the `where.associated` method

Thanks for the PR @saleh-alhaddad. Could you explain the use-case this is trying to solve? Don't `#associated` and `#missing` already cover all cases? ```ruby class Post < ActiveRecord::Base belongs_to :author...