Petrik de Heus comments

Results 175 comments of


                                            Petrik de Heus

[ci skip] Improve accessibility

> (to respond to my comment about windows: I meant the implementation before this PR.) Ah, that makes sense. Thanks!

[ci skip] Improve accessibility

@SleeplessByte It would be nice if we could merge some of these changes. We are getting [PR's ](https://github.com/rails/rails/pull/52838)to fix issues already addressed by this PR.

[ci skip] Improve accessibility

Thanks @SleeplessByte !

[ci skip] Fix documented version for `multiple_file_field_include_hidden`

Hi @schmijos , maybe the original PR makes more sense? https://github.com/rails/rails/pull/46358

I am moving my rails application to rails only api but jbuilder is returning a blank screen

Looking at the source of the error it seems `_helpers` is nil. https://github.com/rails/rails/blob/6-1-stable/actionpack/lib/abstract_controller/helpers.rb#L148 Could you post the whole backtrace of the error?

Randomize Framework order in runs

Flipping the order each time makes sense to me.

Randomize Framework order in runs

I think the following run was reversed: https://tfb-status.techempower.com/results/3c2e9871-9c2a-4ff3-bc31-620f65da4e74. The “last framework” tested is incorrect though.

[ruby] Combine *-sequel frameworks with their main frameworks

~Hmm, ok I'll probably need to merge the directories instead.~ Nevermind, this works now as expected similar to Ruby/agoo: https://github.com/TechEmpower/FrameworkBenchmarks/blob/77513b8d34ce60860d47d9f95e9c5035d605dca9/frameworks/Ruby/agoo/benchmark_config.json#L15

Render URLs without numbers for singular resource routes

I think this requires a CHANGELOG entry, as this is a behavioural change

Merge rspec repos

@JonRowe Yes, I've seen https://github.com/rspec/rspec-monorepo-prototype. But that doesn't keep the commit history as mentioned in https://github.com/rspec/rspec-core/issues/2509. What would you propose would for the next step?