Petrik de Heus
Petrik de Heus
It probably happens because of lines like the following: https://github.com/rails/rails/blob/e5124aed3fdcacb05204391e236c4fd60a1e6e74/activesupport/lib/active_support.rb#L35 Introduced in: https://github.com/rails/rails/pull/47717
Maybe we should move rendering the README on the index to sdoc instead?
Maybe we can do something similar to the guides, and show a warning on other docs: https://github.com/rails/rails/blob/633eb5a9f4f7ed9e638ac5b6b9ee04f323bb61c0/guides/source/active_record_basics.md?plain=1#L1 On the other hand I don't think every gem should have their own...
We could have our own directive that RDoc doesn't recognize, so it would skip it instead. ```:sdoc_include: activesupport/README.rdoc``` It would be a subclass of: https://github.com/ruby/rdoc/blob/4e14158255ad8de64041105470d88f66b6e22e98/lib/rdoc/markup/include.rb I'll try to make a...
Yes, good point @jonathanhefner. I've created https://github.com/rails/rails/pull/50789
@brendanh-katalyst I've added you as co-author. ``` Co-Authored-By: Brendan Hart ``` Do you want an email attached to that commit message comment? ``` Co-Authored-By: Brendan Hart ```
Thanks for working on this @seanpdoyle. Is it possible to split this into two separate PR's? First replace internal usage of 'tag with positional arguments', then add the deprecation. This...
> I think keeping it as a single commit/PR is fine, and maybe better to keep the context in one place 🤔 But shouldn't we try to at least to...
> @p8 ohhhhh, believe me, I tried this 🙂! Ah I see 😄
Maybe we should be using [public-suffix](https://github.com/weppos/publicsuffix-ruby) instead